lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 312/496] hv_netvsc: enable multicast if necessary
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stephen Hemminger <stephen@networkplumber.org>

    [ Upstream commit f03dbb06dc380274e351ca4b1ee1587ed4529e62 ]

    My recent change to netvsc drive in how receive flags are handled
    broke multicast. The Hyper-v/Azure virtual interface there is not a
    multicast filter list, filtering is only all or none. The driver must
    enable all multicast if any multicast address is present.

    Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast")
    Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/hyperv/rndis_filter.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/hyperv/rndis_filter.c
    +++ b/drivers/net/hyperv/rndis_filter.c
    @@ -856,7 +856,7 @@ static void rndis_set_multicast(struct w
    if (flags & IFF_PROMISC) {
    filter = NDIS_PACKET_TYPE_PROMISCUOUS;
    } else {
    - if (flags & IFF_ALLMULTI)
    + if (!netdev_mc_empty(rdev->ndev) || (flags & IFF_ALLMULTI))
    filter |= NDIS_PACKET_TYPE_ALL_MULTICAST;
    if (flags & IFF_BROADCAST)
    filter |= NDIS_PACKET_TYPE_BROADCAST;

    \
     
     \ /
      Last update: 2018-05-28 14:54    [W:4.378 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site