Messages in this thread | | | From | Ulf Hansson <> | Date | Mon, 28 May 2018 13:04:16 +0200 | Subject | Re: [PATCH] mmc: sunxi: mark PM functions as __maybe_unused |
| |
On 25 May 2018 at 23:07, Arnd Bergmann <arnd@arndb.de> wrote: > The newly added runtime-pm functions cause a harmless warning > when CONFIG_PM is disabled: > > drivers/mmc/host/sunxi-mmc.c:1452:12: error: 'sunxi_mmc_runtime_suspend' defined but not used [-Werror=unused-function] > static int sunxi_mmc_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/mmc/host/sunxi-mmc.c:1435:12: error: 'sunxi_mmc_runtime_resume' defined but not used [-Werror=unused-function] > static int sunxi_mmc_runtime_resume(struct device *dev) > > This marks them as __maybe_unused to shut up the warning.
Most mmc drivers uses #ifdef CONFIG_PM instead of the __maybe_unused() option.
It's not a big deal, but consistency is always good. Would you mind changing?
Br Uffe
> > Fixes: 9a8e1e8cc2c0 ("mmc: sunxi: Add runtime_pm support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/mmc/host/sunxi-mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c > index 97c6b79b7d6f..837888b96bd3 100644 > --- a/drivers/mmc/host/sunxi-mmc.c > +++ b/drivers/mmc/host/sunxi-mmc.c > @@ -1432,7 +1432,7 @@ static int sunxi_mmc_remove(struct platform_device *pdev) > return 0; > } > > -static int sunxi_mmc_runtime_resume(struct device *dev) > +static int __maybe_unused sunxi_mmc_runtime_resume(struct device *dev) > { > struct mmc_host *mmc = dev_get_drvdata(dev); > struct sunxi_mmc_host *host = mmc_priv(mmc); > @@ -1449,7 +1449,7 @@ static int sunxi_mmc_runtime_resume(struct device *dev) > return 0; > } > > -static int sunxi_mmc_runtime_suspend(struct device *dev) > +static int __maybe_unused sunxi_mmc_runtime_suspend(struct device *dev) > { > struct mmc_host *mmc = dev_get_drvdata(dev); > struct sunxi_mmc_host *host = mmc_priv(mmc); > -- > 2.9.0 >
| |