lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 088/272] bnxt_en: fix clear flags in ethtool reset handling
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Scott Branden <scott.branden@broadcom.com>

    [ Upstream commit 2373d8d6a7932d28b8e31ea2a70bf6c002d97ac8 ]

    Clear flags when reset command processed successfully for components
    specified.

    Fixes: 6502ad5963a5 ("bnxt_en: Add ETH_RESET_AP support")
    Signed-off-by: Scott Branden <scott.branden@broadcom.com>
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    @@ -2552,16 +2552,20 @@ static int bnxt_reset(struct net_device
    return -EOPNOTSUPP;

    rc = bnxt_firmware_reset(dev, BNXT_FW_RESET_CHIP);
    - if (!rc)
    + if (!rc) {
    netdev_info(dev, "Reset request successful. Reload driver to complete reset\n");
    + *flags = 0;
    + }
    } else if (*flags == ETH_RESET_AP) {
    /* This feature is not supported in older firmware versions */
    if (bp->hwrm_spec_code < 0x10803)
    return -EOPNOTSUPP;

    rc = bnxt_firmware_reset(dev, BNXT_FW_RESET_AP);
    - if (!rc)
    + if (!rc) {
    netdev_info(dev, "Reset Application Processor request successful.\n");
    + *flags = 0;
    + }
    } else {
    rc = -EINVAL;
    }

    \
     
     \ /
      Last update: 2018-05-28 13:10    [W:4.020 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site