lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 474/496] dpaa_eth: fix pause capability advertisement logic
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jake Moroni <mail@jakemoroni.com>

    [ Upstream commit 3021efb440d02bf5b952b6d151c7ffee9bdd49fe ]

    The ADVERTISED_Asym_Pause bit was being improperly set when both
    rx and tx pause were enabled. When rx and tx are both enabled, only
    the ADVERTISED_Pause bit is supposed to be set.

    Signed-off-by: Jake Moroni <mail@jakemoroni.com>
    Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
    +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
    @@ -211,7 +211,7 @@ static int dpaa_set_pauseparam(struct ne
    if (epause->rx_pause)
    newadv = ADVERTISED_Pause | ADVERTISED_Asym_Pause;
    if (epause->tx_pause)
    - newadv |= ADVERTISED_Asym_Pause;
    + newadv ^= ADVERTISED_Asym_Pause;

    oldadv = phydev->advertising &
    (ADVERTISED_Pause | ADVERTISED_Asym_Pause);

    \
     
     \ /
      Last update: 2018-05-28 13:03    [W:4.081 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site