lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 072/185] media: dmxdev: fix error code for invalid ioctls
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mauro Carvalho Chehab <mchehab@s-opensource.com>

    [ Upstream commit a145f64c6107d3aa5a7cec9f8977d04ac2a896c9 ]

    Returning -EINVAL when an ioctl is not implemented is a very
    bad idea, as it is hard to distinguish from other error
    contitions that an ioctl could lead. Replace it by its
    right error code: -ENOTTY.

    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/dvb-core/dmxdev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/dvb-core/dmxdev.c
    +++ b/drivers/media/dvb-core/dmxdev.c
    @@ -1069,7 +1069,7 @@ static int dvb_demux_do_ioctl(struct fil
    break;

    default:
    - ret = -EINVAL;
    + ret = -ENOTTY;
    break;
    }
    mutex_unlock(&dmxdev->mutex);

    \
     
     \ /
      Last update: 2018-05-28 12:10    [W:4.145 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site