Messages in this thread | | | Date | Mon, 28 May 2018 17:40:48 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON |
| |
On Thu, May 24, 2018 at 02:11:30PM -0700, Davidlohr Bueso wrote: > For the purpose of making rhashtable_init() unable to fail, > we can replace the returning -EINVAL with WARN_ONs whenever > the caller passes bogus parameters during initialization. > > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
I don't really see why we need these WARN_ONs. The problem should be quite obvious when you're writing your code.
If you really want them perhaps add them to the ipc code instead?
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |