lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 03/20] signal: make may_ptrace_stop() return bool
    Date
    may_ptrace_stop() already behaves like a boolean function. Let's actually
    declare it as such too.

    Signed-off-by: Christian Brauner <christian@brauner.io>
    ---
    v0->v1:
    * patch unchanged
    ---
    kernel/signal.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/kernel/signal.c b/kernel/signal.c
    index 6c71d6b8d2b8..bc750fb4ddcc 100644
    --- a/kernel/signal.c
    +++ b/kernel/signal.c
    @@ -1889,10 +1889,10 @@ static void do_notify_parent_cldstop(struct task_struct *tsk,
    spin_unlock_irqrestore(&sighand->siglock, flags);
    }

    -static inline int may_ptrace_stop(void)
    +static inline bool may_ptrace_stop(void)
    {
    if (!likely(current->ptrace))
    - return 0;
    + return false;
    /*
    * Are we in the middle of do_coredump?
    * If so and our tracer is also part of the coredump stopping
    @@ -1906,11 +1906,11 @@ static inline int may_ptrace_stop(void)
    * block in TASK_TRACED. But PTRACE_EVENT_EXIT can be reported
    * after SIGKILL was already dequeued.
    */
    - if (unlikely(current->mm->core_state) &&
    - unlikely(current->mm == current->parent->mm))
    - return 0;
    + if (likely(!current->mm->core_state ||
    + current->mm != current->parent->mm))
    + return false;

    - return 1;
    + return true;
    }

    /*
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-05-29 00:03    [W:3.381 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site