lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 049/185] scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit a7043e9529f3c367cc4d82997e00be034cbe57ca ]

    My static checker complains about an out of bounds read:

    drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo()
    error: buffer overflow 'hd->sel_timeout' 255 <= u32max.

    It's true that we probably should have a bounds check here.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/message/fusion/mptctl.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/message/fusion/mptctl.c
    +++ b/drivers/message/fusion/mptctl.c
    @@ -2694,6 +2694,8 @@ mptctl_hp_targetinfo(unsigned long arg)
    __FILE__, __LINE__, iocnum);
    return -ENODEV;
    }
    + if (karg.hdr.id >= MPT_MAX_FC_DEVICES)
    + return -EINVAL;
    dctlprintk(ioc, printk(MYIOC_s_DEBUG_FMT "mptctl_hp_targetinfo called.\n",
    ioc->name));


    \
     
     \ /
      Last update: 2018-05-28 18:44    [W:4.173 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site