lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 179/185] audit: return on memory error to avoid null pointer dereference
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Guy Briggs <rgb@redhat.com>

    [ Upstream commit 23138ead270045f1b3e912e667967b6094244999 ]

    If there is a memory allocation error when trying to change an audit
    kernel feature value, the ignored allocation error will trigger a NULL
    pointer dereference oops on subsequent use of that pointer. Return
    instead.

    Passes audit-testsuite.
    See: https://github.com/linux-audit/audit-kernel/issues/76

    Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
    [PM: not necessary (other funcs check for NULL), but a good practice]
    Signed-off-by: Paul Moore <paul@paul-moore.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/audit.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/kernel/audit.c
    +++ b/kernel/audit.c
    @@ -738,6 +738,8 @@ static void audit_log_feature_change(int
    return;

    ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_FEATURE_CHANGE);
    + if (!ab)
    + return;
    audit_log_task_info(ab, current);
    audit_log_format(ab, " feature=%s old=%u new=%u old_lock=%u new_lock=%u res=%d",
    audit_feature_names[which], !!old_feature, !!new_feature,

    \
     
     \ /
      Last update: 2018-05-28 18:09    [W:4.047 / U:1.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site