lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 209/329] RDMA/ucma: Correct option size check using optlen
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chien Tin Tung <chien.tin.tung@intel.com>

    [ Upstream commit 5f3e3b85cc0a5eae1c46d72e47d3de7bf208d9e2 ]

    The option size check is using optval instead of optlen
    causing the set option call to fail. Use the correct
    field, optlen, for size check.

    Fixes: 6a21dfc0d0db ("RDMA/ucma: Limit possible option size")
    Signed-off-by: Chien Tin Tung <chien.tin.tung@intel.com>
    Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
    Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/core/ucma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/core/ucma.c
    +++ b/drivers/infiniband/core/ucma.c
    @@ -1296,7 +1296,7 @@ static ssize_t ucma_set_option(struct uc
    if (IS_ERR(ctx))
    return PTR_ERR(ctx);

    - if (unlikely(cmd.optval > KMALLOC_MAX_SIZE))
    + if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE))
    return -EINVAL;

    optval = memdup_user((void __user *) (unsigned long) cmd.optval,

    \
     
     \ /
      Last update: 2018-05-28 16:19    [W:4.023 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site