lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 185/329] IB/mlx5: Fix an error code in __mlx5_ib_modify_qp()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 5d414b178e950ce9685c253994cc730893d5d887 ]

    "err" is either zero or possibly uninitialized here. It should be
    -EINVAL.

    Fixes: 427c1e7bcd7e ("{IB, net}/mlx5: Move the modify QP operation table to mlx5_ib")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/hw/mlx5/qp.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/hw/mlx5/qp.c
    +++ b/drivers/infiniband/hw/mlx5/qp.c
    @@ -2809,8 +2809,10 @@ static int __mlx5_ib_modify_qp(struct ib
    mlx5_ib_qp_disable_pagefaults(qp);

    if (mlx5_cur >= MLX5_QP_NUM_STATE || mlx5_new >= MLX5_QP_NUM_STATE ||
    - !optab[mlx5_cur][mlx5_new])
    + !optab[mlx5_cur][mlx5_new]) {
    + err = -EINVAL;
    goto out;
    + }

    op = optab[mlx5_cur][mlx5_new];
    optpar = ib_mask_to_mlx5_opt(attr_mask);

    \
     
     \ /
      Last update: 2018-05-28 16:18    [W:4.279 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site