lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 058/496] mac80211: mesh: fix wrong mesh TTL offset calculation
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Peter Oh <peter.oh@bowerswilkins.com>

    [ Upstream commit c4de37ee2b55deac7d6aeac33e02e3d6be243898 ]

    mesh TTL offset in Mesh Channel Switch Parameters element depends on
    not only Secondary Channel Offset element, but also affected by
    HT Control field and Wide Bandwidth Channel Switch element.
    So use element structure to manipulate mesh channel swich param IE
    after removing its constant attribution to correct the miscalculation.

    Signed-off-by: Peter Oh <peter.oh@bowerswilkins.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/mac80211/ieee80211_i.h | 2 +-
    net/mac80211/mesh.c | 17 ++++++-----------
    2 files changed, 7 insertions(+), 12 deletions(-)

    --- a/net/mac80211/ieee80211_i.h
    +++ b/net/mac80211/ieee80211_i.h
    @@ -1466,7 +1466,7 @@ struct ieee802_11_elems {
    const struct ieee80211_timeout_interval_ie *timeout_int;
    const u8 *opmode_notif;
    const struct ieee80211_sec_chan_offs_ie *sec_chan_offs;
    - const struct ieee80211_mesh_chansw_params_ie *mesh_chansw_params_ie;
    + struct ieee80211_mesh_chansw_params_ie *mesh_chansw_params_ie;
    const struct ieee80211_bss_max_idle_period_ie *max_idle_period_ie;

    /* length of them, respectively */
    --- a/net/mac80211/mesh.c
    +++ b/net/mac80211/mesh.c
    @@ -1253,13 +1253,12 @@ int ieee80211_mesh_csa_beacon(struct iee
    }

    static int mesh_fwd_csa_frame(struct ieee80211_sub_if_data *sdata,
    - struct ieee80211_mgmt *mgmt, size_t len)
    + struct ieee80211_mgmt *mgmt, size_t len,
    + struct ieee802_11_elems *elems)
    {
    struct ieee80211_mgmt *mgmt_fwd;
    struct sk_buff *skb;
    struct ieee80211_local *local = sdata->local;
    - u8 *pos = mgmt->u.action.u.chan_switch.variable;
    - size_t offset_ttl;

    skb = dev_alloc_skb(local->tx_headroom + len);
    if (!skb)
    @@ -1267,13 +1266,9 @@ static int mesh_fwd_csa_frame(struct iee
    skb_reserve(skb, local->tx_headroom);
    mgmt_fwd = skb_put(skb, len);

    - /* offset_ttl is based on whether the secondary channel
    - * offset is available or not. Subtract 1 from the mesh TTL
    - * and disable the initiator flag before forwarding.
    - */
    - offset_ttl = (len < 42) ? 7 : 10;
    - *(pos + offset_ttl) -= 1;
    - *(pos + offset_ttl + 1) &= ~WLAN_EID_CHAN_SWITCH_PARAM_INITIATOR;
    + elems->mesh_chansw_params_ie->mesh_ttl--;
    + elems->mesh_chansw_params_ie->mesh_flags &=
    + ~WLAN_EID_CHAN_SWITCH_PARAM_INITIATOR;

    memcpy(mgmt_fwd, mgmt, len);
    eth_broadcast_addr(mgmt_fwd->da);
    @@ -1321,7 +1316,7 @@ static void mesh_rx_csa_frame(struct iee

    /* forward or re-broadcast the CSA frame */
    if (fwd_csa) {
    - if (mesh_fwd_csa_frame(sdata, mgmt, len) < 0)
    + if (mesh_fwd_csa_frame(sdata, mgmt, len, &elems) < 0)
    mcsa_dbg(sdata, "Failed to forward the CSA frame");
    }
    }

    \
     
     \ /
      Last update: 2018-05-28 15:44    [W:4.942 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site