lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 233/496] xen: xenbus: use put_device() instead of kfree()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arvind Yadav <arvind.yadav.cs@gmail.com>

    [ Upstream commit 351b2bccede1cb673ec7957b35ea997ea24c8884 ]

    Never directly free @dev after calling device_register(), even
    if it returned an error! Always use put_device() to give up the
    reference initialized.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/xen/xenbus/xenbus_probe.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/xen/xenbus/xenbus_probe.c
    +++ b/drivers/xen/xenbus/xenbus_probe.c
    @@ -466,8 +466,11 @@ int xenbus_probe_node(struct xen_bus_typ

    /* Register with generic device framework. */
    err = device_register(&xendev->dev);
    - if (err)
    + if (err) {
    + put_device(&xendev->dev);
    + xendev = NULL;
    goto fail;
    + }

    return 0;
    fail:

    \
     
     \ /
      Last update: 2018-05-28 15:10    [W:4.114 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site