lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 235/496] hv_netvsc: fix locking for rx_mode
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stephen Hemminger <stephen@networkplumber.org>

    [ Upstream commit 35a57b7fef136fa3d5b735ba773f191b95110fa0 ]

    The rx_mode operation handler is different than other callbacks
    in that is not always called with rtnl held. Therefore use
    RCU to ensure that references are valid.

    Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF")
    Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/hyperv/netvsc_drv.c | 11 ++++++++---
    1 file changed, 8 insertions(+), 3 deletions(-)

    --- a/drivers/net/hyperv/netvsc_drv.c
    +++ b/drivers/net/hyperv/netvsc_drv.c
    @@ -89,15 +89,20 @@ static void netvsc_change_rx_flags(struc
    static void netvsc_set_rx_mode(struct net_device *net)
    {
    struct net_device_context *ndev_ctx = netdev_priv(net);
    - struct net_device *vf_netdev = rtnl_dereference(ndev_ctx->vf_netdev);
    - struct netvsc_device *nvdev = rtnl_dereference(ndev_ctx->nvdev);
    + struct net_device *vf_netdev;
    + struct netvsc_device *nvdev;

    + rcu_read_lock();
    + vf_netdev = rcu_dereference(ndev_ctx->vf_netdev);
    if (vf_netdev) {
    dev_uc_sync(vf_netdev, net);
    dev_mc_sync(vf_netdev, net);
    }

    - rndis_filter_update(nvdev);
    + nvdev = rcu_dereference(ndev_ctx->nvdev);
    + if (nvdev)
    + rndis_filter_update(nvdev);
    + rcu_read_unlock();
    }

    static int netvsc_open(struct net_device *net)

    \
     
     \ /
      Last update: 2018-05-28 15:09    [W:4.048 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site