Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 24 May 2018 10:28:44 +0200 | Subject | Re: [PATCH v2 2/5] gpio: syscon: Add gpio-syscon for rockchip |
| |
On Wed, May 23, 2018 at 5:12 PM, Heiko Stübner <heiko@sntech.de> wrote:
> So the gpio controller should definitly also be a subnode. > > The gpio in question is called "mute", so I'd think the gpio-syscon driver > should just define a "rockchip,rk3328-gpio-mute" compatible and contain > all the register voodoo in the driver itself and not define it in the dt. > > So it should probably look like > > grf: syscon at ff100000 { > compatible = "rockchip,rk3328-grf", "syscon", "simple-mfd"; > > [all the other syscon sub-devices] > > gpio_mute: gpio-mute { > compatible = "rockchip,rk3328-gpio-mute"; > gpio-controller; > #gpio-cells = <2>; > };
I'm sceptic.
That doesn't sound like "general purpose input output" at all.
It sounds like special purpose, for a mute button.
Does it use IRQ? I would recommend implementing drivers/input/keyboard/syscon-keys.c in the same vein as drivers/leds/leds-syscon.c so you can avoid indirection through GPIO for no good reason at all.
I already have other good uses for such a generic input driver.
Yours, Linus Walleij
| |