Messages in this thread | | | From | Doug Meyer <> | Date | Wed, 23 May 2018 13:39:42 -0700 | Subject | Re: [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header |
| |
Dear Logan,
Thank you for the comment. My gmail filters got me and I never saw Bjorn's comments on pci_ids.h. I'll start work on v3 when I get another window of time at work.
Blessings, Doug
On Wed, May 23, 2018 at 1:26 PM, Logan Gunthorpe <logang@deltatee.com> wrote: > > > On 23/05/18 02:18 PM, dmeyer@gigaio.com wrote: >> +#define PCI_DEVICE_ID_MICROSEMI_PFX24XG3 0x8531 > > I think Bjorn asked not to add the device IDs to the pci_ids.h and to > just use the raw IDs in quirks.h. switchtec.c already uses the raw values. > > Besides that, it looks good to me. > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > > > -- > You received this message because you are subscribed to the Google Groups "linux-ntb" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com. > To post to this group, send email to linux-ntb@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/553308ee-9c6f-2e1e-1ce8-03b739d1acb0%40deltatee.com. > For more options, visit https://groups.google.com/d/optout.
| |