Messages in this thread | | | Date | Wed, 23 May 2018 09:32:39 +0200 | From | Jiri Pirko <> | Subject | Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr |
| |
Mon, May 21, 2018 at 10:03:04PM CEST, vladbu@mellanox.com wrote: >Initial net_device implementation used ingress_lock spinlock to synchronize >ingress path of device. This lock was used in both process and bh context. >In some code paths action map lock was obtained while holding ingress_lock. >Commit e1e992e52faa ("[NET_SCHED] protect action config/dump from irqs") >modified actions to always disable bh, while using action map lock, in >order to prevent deadlock on ingress_lock in softirq. This lock was removed >from net_device, so disabling bh, while accessing action map, is no longer >necessary. > >Replace all action idr spinlock usage with regular calls that do not >disable bh. > >Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Please add my tag to v3, with the description changes requested by Cong. Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks!
| |