Messages in this thread | | | Subject | Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI | From | Jens Axboe <> | Date | Tue, 22 May 2018 13:16:54 -0600 |
| |
On 5/22/18 1:13 PM, Christoph Hellwig wrote: > On Tue, May 22, 2018 at 01:09:41PM -0600, Jens Axboe wrote: >> I think Martin and Christoph are objecting to moving the code to >> block/scsi_ioctl.h. I don't care too much about where the code is, but >> think it would be nice to have the definitions in a separate header. But >> if they prefer just pulling in all of SCSI for it, well then I guess >> it's pointless to move the header bits. Seems very heavy handed to me, >> though. > > It might be heavy handed for the 3 remaining users of drivers/ide,
Brutal :-)
> but as long as that stuff just keeps working I'd rather worry about > everyone else, and keep the scsi code where it belongs.
Fine with me then, hopefully we can some day kill it off.
-- Jens Axboe
| |