Messages in this thread | | | Subject | Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI | From | "Martin K. Petersen" <> | Date | Tue, 22 May 2018 14:50:43 -0400 |
| |
Christoph,
> On Tue, May 22, 2018 at 11:15:09AM -0700, Kees Cook wrote: >> Both SCSI and ATAPI share the sense header. In preparation for using the >> struct scsi_sense_hdr more widely, move this into a separate header and >> move the helper function to scsi_ioctl.c which is linked with CONFIG_IDE >> by way of CONFIG_BLK_SCSI_REQUEST. > > Please keep the code where it is and just depend on SCSI on the legacy > ide driver. No need to do gymnastics just for a legacy case.
Yup, I agree.
-- Martin K. Petersen Oracle Linux Engineering
| |