Messages in this thread | | | Subject | Re: [PATCH v2 2/2] kasan: fix memory hotplug during boot | From | David Hildenbrand <> | Date | Tue, 22 May 2018 18:36:49 +0200 |
| |
On 22.05.2018 18:26, Andrey Ryabinin wrote: > > > On 05/22/2018 01:07 PM, David Hildenbrand wrote: >> Using module_init() is wrong. E.g. ACPI adds and onlines memory before >> our memory notifier gets registered. >> >> This makes sure that ACPI memory detected during boot up will not >> result in a kernel crash. >> >> Easily reproducable with QEMU, just specify a DIMM when starting up. > > reproducible >> >> Signed-off-by: David Hildenbrand <david@redhat.com> >> --- > > Fixes: fa69b5989bb0 ("mm/kasan: add support for memory hotplug") > Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > Cc: <stable@vger.kernel.org>
Think this even dates back to:
786a8959912e ("kasan: disable memory hotplug")
> >> mm/kasan/kasan.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c >> index 53564229674b..a8b85706e2d6 100644 >> --- a/mm/kasan/kasan.c >> +++ b/mm/kasan/kasan.c >> @@ -892,5 +892,5 @@ static int __init kasan_memhotplug_init(void) >> return 0; >> } >> >> -module_init(kasan_memhotplug_init); >> +core_initcall(kasan_memhotplug_init); >> #endif >>
--
Thanks,
David / dhildenb
| |