Messages in this thread | | | Subject | Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES | From | "Alex G." <> | Date | Tue, 22 May 2018 10:18:02 -0500 |
| |
On 05/22/2018 10:15 AM, Tyler Baicar wrote: > On 5/22/2018 10:32 AM, Alex G. wrote: >> I think the biggest problem is having a policy to panic on "fatal" >> errors, instead of letting the error handler make that decision. I'd >> much rather kill that stupid policy, but people seem to like it for some >> reason. >> > You can get around that panic and still have the error handled as > AER_FATAL in > the current code. Your FW needs to mark the error as RECOVERABLE and then > set the CPER_SEC_RESET flag.
Of course, that would be ideal. But experience shows that firmware doesn't do this. That's the whole point: firmware sends questionable data.
Alex
> https://elixir.bootlin.com/linux/v4.17-rc6/source/drivers/acpi/apei/ghes.c#L450 > > > Thanks, > Tyler >
| |