Messages in this thread | | | Subject | Re: [PATCH v6 1/2] acpi: apei: Rename ghes_severity() to ghes_cper_severity() | From | "Alex G." <> | Date | Tue, 22 May 2018 08:38:39 -0500 |
| |
On 05/22/2018 03:55 AM, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 3:49 PM, Alexandru Gagniuc <mr.nuke.me@gmail.com> wrote: >> ghes_severity() is a misnomer in this case, as it implies the severity >> of the entire GHES structure. Instead, it maps one CPER value to a >> GHES_SEV* value. ghes_cper_severity() is clearer. > > It looks like the *real* reason for this change is that you > re-introduce ghes_severity() as a different function in the second > patch.
/me holds fist at Borislav
> There are a couple of reasons to avoid that, one of them being that > people will now have to remember what the function did in which kernel > versions.
So?
> Also, the current name is good enough IMO,
Two other reviewers were extremely confused by the vague name, so no, this is not good enough.
> so I'm not going to apply this patch.
| |