Messages in this thread | | | Subject | Re: set_fs(KERNEL_DS) vs iovec | From | Benjamin Herrenschmidt <> | Date | Tue, 22 May 2018 22:44:08 +1000 |
| |
On Tue, 2018-05-22 at 03:20 -0700, Christoph Hellwig wrote: > On Tue, May 22, 2018 at 03:08:35PM +1000, Benjamin Herrenschmidt wrote: > > Hence my question: Is is still acceptable these days to use > > set_fs(KERNEL_DS) for simple cases like this ? > > Not at all. > > > Or is it really > > deprecated and all new users should use the iovec's ? > > Yes, please use iov_iter. It should actually make your code simpler, > too.
In this case it really doesn't :-) But that doesn't matter, I get the message, I'll fix the driver accordingly.
Cheers, Ben.
| |