Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 22 May 2018 12:18:47 +0300 | Subject | Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support |
| |
On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg <bberg@redhat.com> wrote:
> I had a quick chat with Bastien about this. The conclusion was that > reusing the TOGGLE key may be problematic for gnome-settings-daemon. > And the alternative of a new CYCLE key also has some caveats. > > The most straight forward solution is likely to simply handle the > brightness change in the kernel and not report the key to userspace at > all. This should work just fine and at least GNOME will show an on > screen display in response to the brightness change. > > Do you think that approach would work well?
Am I right we are waiting for Daniel's answer?
Btw, I mistakenly thought that patch in the queue for-next, while it's not. So, I'm going to drop it now. Feel free to re-submit a new (better) version.
-- With Best Regards, Andy Shevchenko
| |