Messages in this thread | | | From | Doug Meyer <> | Date | Tue, 22 May 2018 14:08:27 -0700 | Subject | Re: [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On |
| |
[resending because I forgot the mailing lists want plain text mode]
Dear Logan,
I agree. I'll add pci_disable_device().
Blessings, Doug
On Thu, May 17, 2018 at 8:48 AM, Logan Gunthorpe <logang@deltatee.com> wrote: > > Thanks for your hard work on this Doug! > > On 17/05/18 06:00 AM, dmeyer@gigaio.com wrote: > > > + if (pci_enable_device(pdev)) { > > + dev_err(&pdev->dev, "Cannot enable Switchtec device\n"); > > + return; > > + } > > I suspect we should probably cass pci_disable_device() before leaving > this function so it's in the same state we started. Just like we unmap > the mmio. > > Logan > > -- > You received this message because you are subscribed to the Google Groups "linux-ntb" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com. > To post to this group, send email to linux-ntb@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/a0997fec-ba06-0d1d-a43d-fcc1600484f5%40deltatee.com. > For more options, visit https://groups.google.com/d/optout.
| |