Messages in this thread | | | Date | Thu, 3 May 2018 12:56:55 +1000 | From | "Tobin C. Harding" <> | Subject | Re: [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option |
| |
On Wed, May 02, 2018 at 02:56:45PM -0700, Andrew Morton wrote: > On Wed, 2 May 2018 09:33:40 +1000 "Tobin C. Harding" <me@tobin.cc> wrote: > > > Currently if an attempt is made to print a pointer before there is > > enough entropy then '(____ptrval____)' is printed. This makes debugging > > early stage stack traces difficult. We can relax the requirement for > > cryptographically secure hashing when debugging while still maintaining > > pointer hashing behaviour. > > > > Add a command line option 'use-early-random-bytes'. When enabled get > > key material from the hw RNG if available. > > Documentation/admin-guide/kernel-parameters.rst, please. > > > This option should NOT be enabled on production kernels. > > And the documentation should explain why this recommendation is made. > Here was I scratching my head wondering why this feature isn't just > permanently enabled. Still scratching away...
Thanks for the review. I think v2 covers your concerns, it patches Documentation/kernel-parameters
If you are still scratching after reading v2 please do say so, I appreciate the feedback.
thanks, Tobin.
| |