Messages in this thread | | | Date | Thu, 3 May 2018 05:45:29 +0200 | From | Amit Shah <> | Subject | Re: [PATCH 0/6] virtio-console: spec compliance fixes |
| |
(apologies if you received a dup)
On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote: > On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote: > > Turns out virtio console tries to take a buffer out of an active vq. > > Works by sheer luck, and is explicitly forbidden by spec. And while > > going over it I saw that error handling is also broken - > > failure is easy to trigger if I force allocations to fail. > > > > Lightly tested. > > Amit - any feedback before I push these patches?
The changes look good spec-wise.
There are a bunch of tests in avocado-vt that test virtio-console functionality. Can you give those a try before pushing?
Amit -- http://amitshah.net/
| |