Messages in this thread Patch in this message | | | From | Mathieu Malaterre <> | Date | Wed, 2 May 2018 21:27:37 +0200 | Subject | Re: [PATCH] kbuild/debian: Use KBUILD_BUILD_* when set |
| |
On Wed, May 2, 2018 at 1:30 PM, Riku Voipio <riku.voipio@linaro.org> wrote: > On 23 April 2018 at 22:50, Mathieu Malaterre <malat@debian.org> wrote: >> Be nice to the user and check env vars KBUILD_BUILD_USER & >> KBUILD_BUILD_HOST when those are set. > > mkdebian sets the maintainer address as "$name <$email>", but this > patch only sets the email part. I also wonder about the precedence, I > think KBUILD_* should be considered over the generic Debian variables.
I simply tried to re-use the KBUILD_* env vars whenever possible. This did made sense, since:
$ dmesg|grep debian ~ [ 0.000000] Linux version 4.14.0-0.bpo.3-amd64 (debian-kernel@lists.debian.org) (gcc version 6.3.0 20170516 (Debian 6.3.0-18)) #1 SMP Debian 4.14.13-1~bpo9+1 (2018-01-14)
and
$ apt-cache show linux-image-amd64| grep Main ~ Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
I do not believe this should take precedence over DEBEMAIL.
> Riku > >> Signed-off-by: Mathieu Malaterre <malat@debian.org> >> --- >> scripts/package/mkdebian | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian >> index 6adb3a16ba3b..05d58d3ae8a0 100755 >> --- a/scripts/package/mkdebian >> +++ b/scripts/package/mkdebian >> @@ -76,6 +76,8 @@ if [ -n "$DEBEMAIL" ]; then >> email=$DEBEMAIL >> elif [ -n "$EMAIL" ]; then >> email=$EMAIL >> +elif [ -n "$KBUILD_BUILD_USER" ] && [ -n "$KBUILD_BUILD_HOST" ]; then >> + email=$KBUILD_BUILD_USER@$KBUILD_BUILD_HOST >> else >> email=$(id -nu)@$(hostname -f 2>/dev/null || hostname) >> fi >> -- >> 2.11.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
| |