Messages in this thread Patch in this message | | | Date | Wed, 2 May 2018 10:51:19 -0700 | From | tip-bot for Arnaldo Carvalho de Melo <> | Subject | [tip:perf/core] perf tests vmlinux-kallsyms: Use map__for_each_symbol() instead of open coded equivalent |
| |
Commit-ID: d05b861e6da27ccb0d1b882f240890b0ed40adff Gitweb: https://git.kernel.org/tip/d05b861e6da27ccb0d1b882f240890b0ed40adff Author: Arnaldo Carvalho de Melo <acme@redhat.com> AuthorDate: Wed, 25 Apr 2018 12:32:25 -0300 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 26 Apr 2018 13:47:12 -0300
perf tests vmlinux-kallsyms: Use map__for_each_symbol() instead of open coded equivalent
We had this much shorter map__for_each_symbol() helper for ages, use it and kill one more map_type use outside the code, in the tools.
Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: https://lkml.kernel.org/n/tip-iswqjy1elghc5jjvr0nds3nc@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/tests/vmlinux-kallsyms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/vmlinux-kallsyms.c b/tools/perf/tests/vmlinux-kallsyms.c index c7f43afd5f89..a99b0c118541 100644 --- a/tools/perf/tests/vmlinux-kallsyms.c +++ b/tools/perf/tests/vmlinux-kallsyms.c @@ -108,7 +108,7 @@ int test__vmlinux_matches_kallsyms(struct test *test __maybe_unused, int subtest * in the kallsyms dso. For the ones that are in both, check its names and * end addresses too. */ - for (nd = rb_first(&vmlinux_map->dso->symbols[type]); nd; nd = rb_next(nd)) { + map__for_each_symbol(vmlinux_map, sym, nd) { struct symbol *pair, *first_pair; sym = rb_entry(nd, struct symbol, rb_node);
| |