lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings
Hi,

On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@codeaurora.org> wrote:
> +- vdd_l26-supply
> +- vdd_lvs1_lvs2-supply
> +- vdd_lvs1_lvs2-supply
> + Usage: optional (PM8998 only)
> + Value type: <phandle>
> + Definition: phandle of the parent supply regulator of one or more of the
> + regulators for this PMIC.

One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice.

Also on the schematics (and in the PM8998 datasheet) I have this is
"VIN_LVS_1_2". It seems like you should be consistent here and call
this "vin-lvs-1-2-supply".

-Doug

\
 
 \ /
  Last update: 2018-05-02 18:37    [W:0.164 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site