lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC resend 1/2] modpost: delete stale comment
2018-03-23 6:05 GMT+09:00 Rasmus Villemoes <linux@rasmusvillemoes.dk>:
> Commit (7840fea200cd "kbuild: Fix computing srcversion for modules")
> fixed the comment above parse_source_files to refer to the new source_
> line, but left this one behind that could still give the impression that
> drivers/net/dummy.c appears in the deps_ variable.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> Resending because I didn't reach any current kbuild maintainers nor
> the kbuild mailing list.
>
> scripts/mod/sumversion.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c
> index 944418da9fe3..0f6dcb4011a8 100644
> --- a/scripts/mod/sumversion.c
> +++ b/scripts/mod/sumversion.c
> @@ -330,14 +330,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md)
> goto out;
> }
>
> - /* There will be a line like so:
> - deps_drivers/net/dummy.o := \
> - drivers/net/dummy.c \
> - $(wildcard include/config/net/fastroute.h) \
> - include/linux/module.h \
> -
> - Sum all files in the same dir or subdirs.
> - */
> + /* Sum all files in the same dir or subdirs. */
> while ((line = get_next_line(&pos, file, flen)) != NULL) {
> char* p = line;
>
> --
> 2.15.1
>


Applied to linux-kbuild/fixes. Thanks!



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2018-05-02 17:52    [W:0.080 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site