Messages in this thread | | | Date | Wed, 2 May 2018 15:55:56 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 3/7] clocksource: Initialize cs->wd_list |
| |
On Wed, May 02, 2018 at 03:37:30PM +0200, Thomas Gleixner wrote: > On Mon, 30 Apr 2018, Peter Zijlstra wrote: > > > A number of places relies on list_empty(&cs->wd_list), however the > > list_head does not get initialized. Do so upon registration, such that > > thereafter it is possible to rely on list_empty() correctly reflecting > > the list membership status. > > > > Tested-by: Diego Viola <diego.viola@gmail.com> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > The next patch is marked for stable, but this one not. Confused
Patch ordering issue mostly. I only marked stable those that fix the immediate/reported problem.
I noticed this while working on the code, this fixes, afaict, a pre-existing issue, where the current code relies on list_empty(&->wd_list), but we don't actually initialize it at all.
Marking it stable is probably fine, but I didn't go to great lengths to test the individual code paths affected.
| |