Messages in this thread | | | Subject | Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats | From | Zumeng Chen <> | Date | Wed, 2 May 2018 18:27:54 +0800 |
| |
On 2018年05月02日 13:12, Michael Chan wrote: > On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen <zumeng.chen@gmail.com> wrote: > >> diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h >> index 3b5e98e..c61d83c 100644 >> --- a/drivers/net/ethernet/broadcom/tg3.h >> +++ b/drivers/net/ethernet/broadcom/tg3.h >> @@ -3102,6 +3102,7 @@ enum TG3_FLAGS { >> TG3_FLAG_ROBOSWITCH, >> TG3_FLAG_ONE_DMA_AT_ONCE, >> TG3_FLAG_RGMII_MODE, >> + TG3_FLAG_HALT, > I think you should be able to use the existing INIT_COMPLETE flag
No, it will bring the uncertain factors into the existed complicate logic of INIT_COMPLETE. And I think it's very simple logic here to fix the meaningless hw_stats reading and the problem of commit f5992b72. I even suspect if you have read INIT_COMPLETE related codes carefully.
Cheers, Zumeng > and > not have to add a new flag. > >> /* Add new flags before this comment and TG3_FLAG_NUMBER_OF_FLAGS */ >> TG3_FLAG_NUMBER_OF_FLAGS, /* Last entry in enum TG3_FLAGS */ >> -- >> 2.9.3 >>
| |