Messages in this thread | | | From | Michael Chan <> | Date | Tue, 1 May 2018 22:12:54 -0700 | Subject | Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats |
| |
On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen <zumeng.chen@gmail.com> wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..c61d83c 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@ -3102,6 +3102,7 @@ enum TG3_FLAGS { > TG3_FLAG_ROBOSWITCH, > TG3_FLAG_ONE_DMA_AT_ONCE, > TG3_FLAG_RGMII_MODE, > + TG3_FLAG_HALT,
I think you should be able to use the existing INIT_COMPLETE flag and not have to add a new flag.
> > /* Add new flags before this comment and TG3_FLAG_NUMBER_OF_FLAGS */ > TG3_FLAG_NUMBER_OF_FLAGS, /* Last entry in enum TG3_FLAGS */ > -- > 2.9.3 >
| |