lkml.org 
[lkml]   [2018]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME
    On Sat, May 19, 2018 at 5:05 AM, Joe Perches <joe@perches.com> wrote:
    > On Fri, 2018-05-18 at 23:29 +0300, Andy Shevchenko wrote:
    >> On Fri, May 18, 2018 at 12:10 PM, Joe Perches <joe@perches.com> wrote:
    >> > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote:
    >> > > On Thu 2018-05-10 08:45:29, Joe Perches wrote:
    >> > > [ 0.000000] libftrace: ftrace: allocating 40753 entries in 160 pages
    >> > > [ 0.004008] apic: APIC: Switch to symmetric I/O mode setup
    >> >
    >> > I believe the uppercase APIC: bit should be removed.
    >>
    >> I disagree on lowering the case of some prefixes.
    >>
    >> In the case when kernel crashes at boot time and only what you have is
    >> what on your screen it's much better to catch with different cases
    >> than if everything would be either upper or lower.
    >
    > I don't parse.
    > My suggestion is to make "apic: " the only prefix.

    What I mean is after your patch it would be like:

    subsys1: ...
    ...
    framework1: ...
    ...
    subsys2: ...
    ...

    What I meant is what you can see in any current log, something like:

    subsys1: ...
    ...
    FRAMEWORK1: ...
    ...
    subsys2: ...
    ...

    When you see such on a long screen, you can momentarely put your eyes
    on string in question.


    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2018-05-19 20:28    [W:3.477 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site