Messages in this thread | | | Date | Fri, 18 May 2018 13:08:08 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 04/10] locking: export osq_lock()/osq_unlock() |
| |
On Fri, May 18, 2018 at 06:18:04AM -0400, Kent Overstreet wrote: > On Fri, May 18, 2018 at 11:52:04AM +0200, Peter Zijlstra wrote: > > On Fri, May 18, 2018 at 03:49:06AM -0400, Kent Overstreet wrote: > > > > No.. and most certainly not without a _very_ good reason. > > Ok, can I ask why?
Because it is an internal helper for lock implementations that want to do optimistic spinning, it isn't a lock on its own and lacks several things you would expect.
Using it is tricky and I don't trust random module authors to get 1+1 right, let alone use this thing correctly (no judgement on your code, just in general).
> Here's what it's for:
I'll try and have a look soon :-) But does that really _have_ to live in a module?
| |