Messages in this thread |  | | Subject | Re: [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver | From | "H. Nikolaus Schaller" <> | Date | Wed, 16 May 2018 16:37:23 +0200 |
| |
> Am 16.05.2018 um 16:31 schrieb Linus Walleij <linus.walleij@linaro.org>: > > On Wed, May 16, 2018 at 3:32 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote: >>> Am 16.05.2018 um 13:53 schrieb Linus Walleij <linus.walleij@linaro.org>: >>> On Sat, Apr 28, 2018 at 6:31 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote: >>> >>>> V5: >>>> * fix wrong split up between patches 1/7and 2/7. >>> >>> I applied patches 1, 2, 3 so we get some movement on the patch >>> set and not too much for you to rebase. >> >> thanks! >> >> Well, I already had edited the commit messages for resending... >> >>> >>> It's fine to just resend the rest next time. >> >> There is only one point open before resending: >> >> what is the preferred style to be used for PCAL_GPIO_MASK? >> >> * GENMASK(4, 0) >> * or 0x1f > > No strong opinion... sorry. Whatever you & the other driver > contributors are most convenient with.
Ok, then let's keep the GENMASK(4, 0) since nobody did complain about it.
BR and thanks, Nikolaus
|  |