Messages in this thread | | | Date | Mon, 14 May 2018 09:52:23 +0200 | From | Antoine Tenart <> | Subject | Re: [PATCH] net: mvpp2: fix mvpp2_tx()'s return type |
| |
Hi Luc,
On Tue, Apr 24, 2018 at 03:16:53PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
I don't think this has been applied yet, so,
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Thanks! Antoine
> --- > drivers/net/ethernet/marvell/mvpp2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c > index 54a038943..355910345 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++ b/drivers/net/ethernet/marvell/mvpp2.c > @@ -6926,7 +6926,7 @@ static int mvpp2_tx_tso(struct sk_buff *skb, struct net_device *dev, > } > > /* Main tx processing */ > -static int mvpp2_tx(struct sk_buff *skb, struct net_device *dev) > +static netdev_tx_t mvpp2_tx(struct sk_buff *skb, struct net_device *dev) > { > struct mvpp2_port *port = netdev_priv(dev); > struct mvpp2_tx_queue *txq, *aggr_txq; > -- > 2.17.0 >
-- Antoine Ténart, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
| |