Messages in this thread | | | Date | Fri, 11 May 2018 21:10:11 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy |
| |
On Fri, May 11, 2018 at 01:51:28PM -0500, Dan Murphy wrote: > Andrew > > On 05/11/2018 01:30 PM, Andrew Lunn wrote: > > On Fri, May 11, 2018 at 01:08:19PM -0500, Dan Murphy wrote: > >> Add support for the DP83811 phy. > >> > >> The DP83811 supports both rgmii and sgmii interfaces. > >> There are 2 part numbers for this the DP83TC811R does not > >> reliably support the SGMII interface but the DP83TC811S will. > >> > >> There is not a way to differentiate these parts from the > >> hardware or register set. So this is controlled via the DT > >> to indicate which phy mode is required. Or the part can be > >> strapped to a certain interface. > >> > >> Data sheet can be found here: > >> http://www.ti.com/product/DP83TC811S-Q1/description > >> http://www.ti.com/product/DP83TC811R-Q1/description > >> > >> Signed-off-by: Dan Murphy <dmurphy@ti.com> > > > > Hi Dan > > > > It is normal to add any Reviewed-by, or Tested-by: tags you received, > > so long as you don't make major changes. > > > > Thanks for the reminder. > > I usually add them if I get them explicitly stated in the review.
Humm, i thought i had given one. But i cannot find it in the mail archive. Going senile :-(
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |