Messages in this thread | | | Date | Tue, 1 May 2018 14:27:02 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v2 2/3] power: supply: add cros-ec USBPD charger driver. |
| |
On Tue, 01 May 2018, Sebastian Reichel wrote:
> Hi Enric, > > On Mon, Apr 30, 2018 at 03:14:02PM +0200, Enric Balletbo i Serra wrote: > > From: Sameer Nanda <snanda@chromium.org> > > > > This driver gets various bits of information about what is connected to > > USB PD ports from the EC and converts that into power_supply properties. > > > > Signed-off-by: Sameer Nanda <snanda@chromium.org> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > --- > > > > Changes in v2: > > - [2/3] Add SPDX header, use devm_ variant and drop .owner > > - [2/3] Removed the PD log functionality (will be send on a follow up patch) > > - [2/3] Removed the extra custom sysfs attributes (will be send on a follow up patch) > > Thanks, it makes reviewing the patchset easier. > > > drivers/power/supply/Kconfig | 10 + > > drivers/power/supply/Makefile | 1 + > > drivers/power/supply/cros_usbpd-charger.c | 511 ++++++++++++++++++++++ > > include/linux/mfd/cros_ec.h | 2 + > > 4 files changed, 524 insertions(+) > > create mode 100644 drivers/power/supply/cros_usbpd-charger.c
[...]
Sebastian,
When you review a patch, would you mind chopping/snipping unnecessary text please? The chunks in-between the ones you reply to.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |