Messages in this thread |  | | Date | Tue, 10 Apr 2018 11:27:51 +1000 (AEST) | From | Finn Thain <> | Subject | Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl |
| |
On Mon, 9 Apr 2018, Geert Uytterhoeven wrote:
> On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain <fthain@telegraphics.com.au> wrote: > > The 'eject' shell command may send various different ioctl commands. > > This leads to error messages on the console even though the FDEJECT > > ioctl succeeds. > > > > ~# eject floppy > > SWIM floppy_ioctl: unknown cmd 21257 > > SWIM floppy_ioctl: unknown cmd 1 > > > > Don't log an error message for an invalid ioctl, just do as the > > swim3 driver does and return -ENOTTY. > > > > Cc: Laurent Vivier <lvivier@redhat.com> > > Cc: Jens Axboe <axboe@kernel.dk> > > Tested-by: Stan Johnson <userm57@yahoo.com> > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Looks like amiflop can use a similar fix. >
Right. I'll prepare a new patch for that and send it separately.
--
> Gr{oetje,eeting}s, > > Geert > >
|  |