Messages in this thread |  | | From | Evan Green <> | Date | Mon, 09 Apr 2018 20:42:32 +0000 | Subject | Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs |
| |
On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd <swboyd@chromium.org> wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56) > > From: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > > > Command DB provides information on shared resources like clocks, > > regulators etc., probed at boot by the remote subsytem and made > > available in shared memory. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > >
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > + reserved-memory { > > + [...] > > + qcom,cmd-db@85fe0000 {
> Nitpick: This may want to be called 'memory@85fe0000' because we prefer > generic node names.
Another nit: the cmd-db region seems to need "no-map" to make the example actually work.
Reviewed-by: Evan Green <evgreen@chromium.org>
-Evan
|  |