lkml.org 
[lkml]   [2018]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters
    From
    Date
    On Mon, 2018-04-09 at 14:10 +0100, Gustavo Pimentel wrote:
    > Hi Joe,

    Hello Gustavo.

    > On 09/04/2018 11:25, Joe Perches wrote:
    > > On Mon, 2018-04-09 at 10:41 +0100, Gustavo Pimentel wrote:
    > > > Replaces lower into upper case characters in comments and debug printks.
    > > >
    > > > This is an attempt to keep the messages coherent within the designware
    > > > driver.
    > >
    > > It'd be nice to make all the dwc drivers use the same
    > > message wording.
    > >
    > > For instance:
    > >
    > > drivers/pci/dwc/pci-keystone.c: dev_err(dev, "phy link never came up\n");
    > > drivers/pci/dwc/pcie-designware.c: dev_err(pci->dev, "phy link never came up\n");
    > > drivers/pci/host/pcie-xilinx-nwl.c: dev_err(dev, "PHY link never came up\n");
    >
    > I also agree, I added a task to my backlog to fix that. However, this task
    > shouldn't be done in this patch series since it's a more broader task involving
    > many drivers and different maintainers. Agree?

    Right.

    I was just highlighting the inconsistency.
    So, no worries. Whenever.

    \
     
     \ /
      Last update: 2018-04-09 16:26    [W:5.916 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site