Messages in this thread |  | | From | Geert Uytterhoeven <> | Date | Mon, 9 Apr 2018 15:14:29 +0200 | Subject | Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl |
| |
On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain <fthain@telegraphics.com.au> wrote: > The 'eject' shell command may send various different ioctl commands. > This leads to error messages on the console even though the FDEJECT > ioctl succeeds. > > ~# eject floppy > SWIM floppy_ioctl: unknown cmd 21257 > SWIM floppy_ioctl: unknown cmd 1 > > Don't log an error message for an invalid ioctl, just do as the > swim3 driver does and return -ENOTTY. > > Cc: Laurent Vivier <lvivier@redhat.com> > Cc: Jens Axboe <axboe@kernel.dk> > Tested-by: Stan Johnson <userm57@yahoo.com> > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Looks like amiflop can use a similar fix.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |