Messages in this thread |  | | Date | Mon, 9 Apr 2018 14:39:10 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 2/2] alx: add disable_wol paramenter |
| |
On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: > The WoL feature was reported broken and will lead to > the system resume immediately after suspending. > This symptom is not happening on every system, so adding > disable_wol option and disable WoL by default to prevent the issue from > happening again.
> const char alx_drv_name[] = "alx"; > > +/* disable WoL by default */ > +bool disable_wol = 1; > +module_param(disable_wol, bool, 0); > +MODULE_PARM_DESC(disable_wol, "Disable Wake on Lan feature"); > +
Hi AceLan
This seems like you are papering over the cracks. And module parameters are not liked.
Please try to find the real problem.
Andrew
|  |