lkml.org 
[lkml]   [2018]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 154/293] ACPI: EC: Fix EC command visibility for dynamic debug
    Date
    From: Lv Zheng <lv.zheng@intel.com>

    [ Upstream commit 4625d752e600c116e6327f9d7fc16e8f5be107e9 ]

    acpi_ec_cmd_string() currently is only enabled for "DEBUG" macro, but users
    trend to use CONFIG_DYNAMIC_DEBUG and enable ec.c pr_debug() print-outs by
    "dyndbg='file ec.c +p'". In this use case, all command names are turned
    into UNDEF and the log is confusing. This affects bugzilla triage work.

    This patch fixes this issue by enabling acpi_ec_cmd_string() for
    CONFIG_DYNAMIC_DEBUG.

    Tested-by: Wang Wendy <wendy.wang@intel.com>
    Tested-by: Feng Chenzhou <chenzhoux.feng@intel.com>
    Signed-off-by: Lv Zheng <lv.zheng@intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/acpi/ec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
    index 38136d608471..217b0bac33d9 100644
    --- a/drivers/acpi/ec.c
    +++ b/drivers/acpi/ec.c
    @@ -317,7 +317,7 @@ static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
    ec->timestamp = jiffies;
    }

    -#ifdef DEBUG
    +#if defined(DEBUG) || defined(CONFIG_DYNAMIC_DEBUG)
    static const char *acpi_ec_cmd_string(u8 cmd)
    {
    switch (cmd) {
    --
    2.15.1
    \
     
     \ /
      Last update: 2018-04-09 04:11    [W:2.830 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site