lkml.org 
[lkml]   [2018]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 076/189] selftests/bpf: fix test_dev_cgroup
    Date
    From: Alexei Starovoitov <ast@kernel.org>

    [ Upstream commit 8e6875250a1189e0d8db8b05e18abe63c2744521 ]

    The test incorrectly doing
    mkdir /mnt/cgroup-test-work-dirtest-bpf-based-device-cgroup
    instead of
    mkdir /mnt/cgroup-test-work-dir/test-bpf-based-device-cgroup

    somehow such mkdir succeeds and new directory appears:
    /mnt/cgroup-test-work-dir/cgroup-test-work-dirtest-bpf-based-device-cgroup

    Later cleanup via nftw("/mnt/cgroup-test-work-dir", ...);
    doesn't walk this directory.
    "rmdir /mnt/cgroup-test-work-dir" succeeds, but bpf program and
    dangling cgroup stays in memory.
    That's a separate issue on a cgroup side.
    For now fix the test.

    Fixes: 37f1ba0909df ("selftests/bpf: add a test for device cgroup controller")
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    tools/testing/selftests/bpf/test_dev_cgroup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/bpf/test_dev_cgroup.c b/tools/testing/selftests/bpf/test_dev_cgroup.c
    index 02c85d6c89b0..070bc3c9a873 100644
    --- a/tools/testing/selftests/bpf/test_dev_cgroup.c
    +++ b/tools/testing/selftests/bpf/test_dev_cgroup.c
    @@ -19,7 +19,7 @@

    #define DEV_CGROUP_PROG "./dev_cgroup.o"

    -#define TEST_CGROUP "test-bpf-based-device-cgroup/"
    +#define TEST_CGROUP "/test-bpf-based-device-cgroup/"

    int main(int argc, char **argv)
    {
    --
    2.15.1
    \
     
     \ /
      Last update: 2018-04-09 05:58    [W:4.231 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site