Messages in this thread |  | | Subject | Re: [PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System | From | Randy Dunlap <> | Date | Sat, 7 Apr 2018 09:37:21 -0700 |
| |
On 04/07/2018 06:59 AM, Craig Tatlor wrote: > This patch adds a driver for the BMS (Battery Monitoring System) > block of the PM8941 PMIC, it uses a lookup table defined in the > device tree to generate a capacity from the BMS supplied OCV, it > then ammends the coulomb counter to that to increase the accuracy > of the estimated capacity. > > Signed-off-by: Craig Tatlor <ctatlor97@gmail.com> > --- > drivers/power/supply/Kconfig | 9 + > drivers/power/supply/Makefile | 1 + > drivers/power/supply/qcom_bms.c | 500 ++++++++++++++++++++++++++++++++ > 3 files changed, 510 insertions(+) > create mode 100644 drivers/power/supply/qcom_bms.c
> diff --git a/drivers/power/supply/qcom_bms.c b/drivers/power/supply/qcom_bms.c > new file mode 100644 > index 000000000000..5aa6e906d1b9 > --- /dev/null > +++ b/drivers/power/supply/qcom_bms.c > @@ -0,0 +1,500 @@
Hi,
> +static unsigned int between(int left, int right, int val) > +{ > + if (left <= val && val >= right)
maybe double-check those if() conditions? [or I need my morning coffee]
> + return 1; > + > + return 0; > +}
thanks, -- ~Randy
|  |