Messages in this thread |  | | Subject | Re: [PATCH 05/20] afs: Implement @sys substitution handling | From | Nikolay Borisov <> | Date | Fri, 6 Apr 2018 20:54:53 +0300 |
| |
On 6.04.2018 11:13, David Howells wrote: > Al Viro <viro@ZenIV.linux.org.uk> wrote: > >> lookup_one_len() seriously depends upon exclusive lock > > In the code it says: > > WARN_ON_ONCE(!inode_is_locked(base->d_inode)); > > which checks i_rwsem, but in the banner comment it says: > > * The caller must hold base->i_mutex. > > is one of these wrong?
Before the switch to i_rwsem, inodes had only i_mutex, so in fact the comment is likely stale.
> > David >
|  |