lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 09/67] ALSA: pcm: potential uninitialized return values
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 5607dddbfca774fb38bffadcb077fe03aa4ac5c6 upstream.

    Smatch complains that "tmp" can be uninitialized if we do a zero size
    write.

    Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/core/oss/pcm_oss.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/core/oss/pcm_oss.c
    +++ b/sound/core/oss/pcm_oss.c
    @@ -1326,7 +1326,7 @@ static ssize_t snd_pcm_oss_write2(struct
    static ssize_t snd_pcm_oss_write1(struct snd_pcm_substream *substream, const char __user *buf, size_t bytes)
    {
    size_t xfer = 0;
    - ssize_t tmp;
    + ssize_t tmp = 0;
    struct snd_pcm_runtime *runtime = substream->runtime;

    if (atomic_read(&substream->mmap_count))
    @@ -1433,7 +1433,7 @@ static ssize_t snd_pcm_oss_read2(struct
    static ssize_t snd_pcm_oss_read1(struct snd_pcm_substream *substream, char __user *buf, size_t bytes)
    {
    size_t xfer = 0;
    - ssize_t tmp;
    + ssize_t tmp = 0;
    struct snd_pcm_runtime *runtime = substream->runtime;

    if (atomic_read(&substream->mmap_count))

    \
     
     \ /
      Last update: 2018-04-06 16:19    [W:4.073 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site